Store creation M1: unit tests for coordinators #8026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no use case in the app so far.
…ator` with `storeCreationFromLogin` configuration.
…ingStores` configurations.
…cker configurations.
jaclync
added
the
type: technical debt
Generated by 🚫 dangerJS |
Collaborator
You can test the changes from this Pull Request by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7879
Description
The main goal of this PR is to add unit tests for three coordinators that were added/updated for store creation M1:
LoggedOutStoreCreationCoordinatorTests,StoreCreationCoordinatorTests, andStorePickerCoordinatorTests. I tried looking into testing the tap action on the navigation bar button, but couldn't find a way - please lemme know if you know of a way. I also thought about mocking the M1 web implementation for store creation results, but decided not to since we're working on M2 to replace the M1 implementation.Also, as per discussion in p1666774134269229/1666768545.000749-slack-CGPNUU63E, we agreed to update
Coordinator.navigationControllerto be immutable. I made this change in 641eed0 since was working on changes for coordinators.Testing instructions
The app layer changes are not user-facing, just CI should be sufficient.
RELEASE-NOTES.txtif necessary.